Opened 3 years ago

Closed 3 years ago

#102 closed defect (fixed)

argument mismatch with inichim_newstart

Reported by: emillour Owned by: emillour
Priority: major Milestone:
Component: MARS GCM Version:
Keywords: Cc:

Description (last modified by emillour)

inichim_newstart is called either from testphys1d or newstart.

However inichim_newstart arguments are:

      subroutine inichim_newstart(ngrid, nq, pq, qsurf, ps, &
		                                  flagh2o, flagthermo)

whereas call from testphys1d is:

         call inichim_newstart(q,psurf,sig,nq,latitude,longitude,
	     $   cell_area,thermo,qsurf)

and from newstart:

          call inichim_newstart(ngridmx, nqtot, q, qsurf, ps, 
     &                          flagh2o, flagthermo)

Clearly the problem is on the testphys1d side, especially since the assumed shapes and sizes of arguments "q,qsurf,ps" in inichim_newstart seem only compatible with being on the scalar dynamics grid...

Todo:

  • make inichim_newstart a module
  • adapt it so that it can be called either from the 1D model or newstart

Done in r2672

Change History (1)

comment:1 Changed 3 years ago by emillour

Description: modified (diff)
Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.