Changeset 3057

Timestamp:

Sep 27, 2023, 8:42:36 PM (16 months ago)

Author:

abierjon

Message:

Mars GCM:
Fix ticket #141 : when doing a log interpolation in zrecast (e.g. for density),
negative and null values are changed into a very small positive value (below
the numerical precision) so that the log interpolation yields a null value.

+ add '_FillValue' attribute (redundant with 'missing_value') checks and
outputs in zrecast to comply with newest NCO versions (part of ticket #152)

YL+AB

Location:

trunk/LMDZ.MARS

Files:

• changelog.txt (modified) (1 diff)
• util/zrecast.F90 (modified) (6 diffs)

trunk/LMDZ.MARS/changelog.txt

@@ -4220 +4220 @@
 Add extra tests for XIOS output: only combine and send fields to XIOS if the
 user requests them in one of the output files.
+
+== 27/09/2023 == YL+AB
+Fix ticket #141 : when doing a log interpolation in zrecast (e.g. for density), negative and null values are changed into a very small positive value (below the numerical precision) so that the log interpolation yields a null value.
++ add '_FillValue' attribute (redundant with 'missing_value') checks and outputs in zrecast to comply with newest NCO versions (part of ticket #152)

trunk/LMDZ.MARS/util/zrecast.F90

@@ -1567 +1567 @@
     stop
   endif
+  ierr=NF_PUT_ATT_REAL(outfid,za_varid,'_FillValue',NF_REAL,1,miss_val) ! redundant attribute for newer NCO versions
+  if (ierr.ne.NF_NOERR) then
+    write(*,*) "Error: Problem writing _FillValue for zareoid"
+    stop
+  endif
 else ! above areoid or above local surface vertical coordinate
   ! pressure dataset
@@ -1592 +1597 @@
   if (ierr.ne.NF_NOERR) then
     write(*,*) "Error: Problem writing missing_value for pressure"
+    stop
+  endif
+  ierr=NF_PUT_ATT_REAL(outfid,p_varid,'_FillValue',NF_REAL,1,miss_val) ! redundant attribute for newer NCO versions
+  if (ierr.ne.NF_NOERR) then
+    write(*,*) "Error: Problem writing _FillValue for pressure"
     stop
   endif
@@ -1712 +1722 @@
     write(*,*) "Found missing_value ",miss_val
     j=j+1
-  else ! no 'missing_value' attribute, set miss_val to default
-    miss_val=miss_val_def
+  else ! no 'missing_value' attribute, look for '_FillValue' attribute
+    ierr=NF_GET_ATT_REAL(infid,tmpvarid,"_FillValue",miss_val)
+    if (ierr.eq.NF_NOERR) then ! found '_FillValue' attribute
+      write(*,*) "Found missing_value ",miss_val
+      j=j+1
+    else ! no 'missing_value' attribute, set miss_val to default
+      miss_val=miss_val_def
+    endif
   endif
   
@@ -1720 +1736 @@
   if (ierr.ne.NF_NOERR) then
     write(*,*) "Error, failed to write missing_value attribute"
+    stop
+  endif
+  ierr=NF_PUT_ATT_REAL(outfid,var_id(i),'_FillValue',NF_REAL,1,miss_val) ! redundant attribute for newer NCO versions
+  if (ierr.ne.NF_NOERR) then
+    write(*,*) "Error, failed to write _FillValue attribute"
     stop
   endif
@@ -2864 +2885 @@
         za(kloop)=z_gcm(iloop,jloop,kloop,tloop)
         ! store log values along altitude
-        logq(kloop)=log(gcmdata(iloop,jloop,kloop,tloop))
+        if (gcmdata(iloop,jloop,kloop,tloop).gt.0) then ! sanity check to handle small negative or null values
+          logq(kloop)=log(gcmdata(iloop,jloop,kloop,tloop))
+        else ! gcmdata<=0
+          logq(kloop)=-1000 ! yields a value of 1e-435 for q that is well below the numerical precision => 0
+        endif ! gcmdata>0
       enddo !kloop
       
@@ -3028 +3053 @@
         z(kloop)=z_gcm(iloop,jloop,kloop,tloop)
         ! store log values along altitude
-        logq(kloop)=log(gcmdata(iloop,jloop,kloop,tloop))
+        if (gcmdata(iloop,jloop,kloop,tloop).gt.0) then ! sanity check to handle small negative or null values
+          logq(kloop)=log(gcmdata(iloop,jloop,kloop,tloop))
+        else ! gcmdata<=0
+          logq(kloop)=-1000 ! yields a value of 1e-435 for q that is well below the numerical precision => 0
+        endif ! gcmdata>0
       enddo !kloop