Changeset 4081 for trunk/LMDZ.GENERIC/libf/phygeneric/rad_correlatedk_init_stellar.F90

Timestamp:

Feb 24, 2026, 9:59:11 AM (9 days ago)

Author:

emillour

Message:

Generic PCM:
OpenMP bug fix in "rad_correlatedk_stellar_spectrum", all intermediate computations
should be done by all OpenMp? threads.
While at it did some cleanup:

• added some OMP threadprivate statements in radcommon_h.F90 (not alwyas necessary, but best practice is that all saved variables be threadprivate)
• turned rad_blackbody.F into a module and modernized routines.
• use clearer stategy (wrt OpenMP) in "rad_correlatedk_init_thermal.F90" and "rad_correlatedk_init_stellar.F90": have the master read in file and data and then broadcast to all cores.

EM

File:

• trunk/LMDZ.GENERIC/libf/phygeneric/rad_correlatedk_init_stellar.F90 (modified) (2 diffs)

trunk/LMDZ.GENERIC/libf/phygeneric/rad_correlatedk_init_stellar.F90

@@ -34 +34 @@
       use callkeys_mod, only: Fat1AU
       use rad_correlatedk_stellar_spectrum_mod, only: rad_correlatedk_stellar_spectrum 
+      use mod_phys_lmdz_para, only : is_master, bcast
 
       implicit none
@@ -74 +75 @@
       endif
         
-!$OMP MASTER        
-      nb=0
-      ierr=0
-      ! check that the file contains the right number of bands 
-      open(131,file=file_path,form='formatted')
-      read(131,*,iostat=ierr) file_entries
-      do while (ierr==0)
+      if (is_master) then ! only the master needs to read in BWNV(:) from file 
+       nb=0
+       ierr=0
+       ! check that the file contains the right number of bands 
+       open(131,file=file_path,form='formatted')
+       read(131,*,iostat=ierr) file_entries
+       do while (ierr==0)
         read(131,*,iostat=ierr) dummy
         if (ierr==0) nb=nb+1
-      enddo
-      close(131)
+       enddo
+       close(131)
 
-      write(*,*) 'rad_correlatedk_init_stellar: L_NSPECTV = ',L_NSPECTV, 'in the model '
-      write(*,*) '        there are   ',nb, 'entries in ',TRIM(file_path)
-      if(nb.ne.L_NSPECTV) then
+       write(*,*) 'rad_correlatedk_init_stellar: L_NSPECTV = ',L_NSPECTV, 'in the model '
+       write(*,*) '        there are   ',nb, 'entries in ',TRIM(file_path)
+       if(nb.ne.L_NSPECTV) then
          write(*,*) 'MISMATCH !! I stop here'
          call abort_physic("rad_correlatedk_init_stellar","The number of entries in narrowbands_VI.in does not match with L_NSPECTV",1)
-      endif
+       endif
 
-      ! load and display the data
-      open(111,file=file_path,form='formatted')
-      read(111,*) 
-       do M=1,L_NSPECTV-1
+       ! load and display the data
+       open(111,file=file_path,form='formatted')
+       read(111,*) 
+        do M=1,L_NSPECTV-1
          read(111,*) BWNV(M)
-      end do
-      read(111,*) lastband
-      close(111)
-      BWNV(L_NSPECTV)  =lastband(1)
-      BWNV(L_NSPECTV+1)=lastband(2)
-!$OMP END MASTER
-!$OMP BARRIER
+       end do
+       read(111,*) lastband
+       close(111)
+       BWNV(L_NSPECTV)  =lastband(1)
+       BWNV(L_NSPECTV+1)=lastband(2)
 
-      print*,'rad_correlatedk_init_stellar: VI band limits:'
-      do M=1,L_NSPECTV+1
+       print*,'rad_correlatedk_init_stellar: VI band limits:'
+       do M=1,L_NSPECTV+1
          print*,m,'-->',BWNV(M),' cm^-1'
-      end do
-      print*,' '
+       end do
+       print*,' '
+      endif ! of if (is_master)
+
+      ! Broadcast BWNV to all cores
+      call bcast(BWNV)
 
 !     Set up mean wavenumbers and wavenumber deltas.  Units of