Changeset 3989 for trunk/LMDZ.COMMON/libf/evolution/ice_table.F90

Timestamp:

Dec 11, 2025, 12:56:05 PM (5 weeks ago)

Author:

jbclement

Message:

PEM:
Massive structural refactor of the PEM codebase for improved readability, consistency and maintainability. The goal is to modernize, standardize and consolidate the code while removing legacy complexity. In detail, this change:

• Performs large-scale cleanup removing unused code, obsolete routines, duplicated functionality and deprecated initialization logic;
• Removes "*_mod" wrappers;
• Replaces mixed naming conventions with clearer variable names, domain-based file/module names and purpose-based routine names;
• Adds native reading/writing capabilities to the PEM removing the cumbersome dependency on Mars PCM subroutines;
• Centralizes soil/ice/orbital/PEM configuration logic into dedicated modules;
• Simplifies routines and updates calls/interfaces to match the new structure.

This refactor significantly clarifies the codebase and provides a cleaner foundation for forthcoming developments.
JBC

File:

• trunk/LMDZ.COMMON/libf/evolution/ice_table.F90 (moved) (moved from trunk/LMDZ.COMMON/libf/evolution/ice_table_mod.F90) (11 diffs)

trunk/LMDZ.COMMON/libf/evolution/ice_table.F90

@@ -1 @@
-MODULE ice_table_mod
+MODULE ice_table
 
 implicit none
@@ -57 +57 @@
 !!!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-use math_mod,                   only: findroot
-use comsoil_h_PEM,              only: mlayer_PEM, layer_PEM ! Depth of the vertical grid
-use soil_thermalproperties_mod, only: ice_thermal_properties
+use math_toolkit,         only: findroot
+use soil,                 only: mlayer_PEM, layer_PEM ! Depth of the vertical grid
+use soil_thermal_inertia, only: get_ice_TI
 
 implicit none
@@ -74 +74 @@
 real, dimension(ngrid,nslope), intent(out) :: ice_table_depth     ! ice table depth [m]
 real, dimension(ngrid,nslope), intent(out) :: ice_table_thickness ! ice table thickness [m]
-! Locals
-! ------
+! Local variables
+! ---------------
 integer                       :: ig, islope, isoil, isoilend ! loop variables
 real, dimension(nsoil)        :: diff_rho                    ! difference of water vapor density between the surface and at depth [kg/m^3]
@@ -129 +129 @@
     do ig = 1,ngrid
         if (ice_table_depth(ig,islope) > previous_icetable_depth(ig,islope) .and. previous_icetable_depth(ig,islope) >= 0) then
-            call ice_thermal_properties(.false.,1.,regolith_inertia(ig,islope),wice_inertia)
+            call get_ice_TI(.false.,1.,regolith_inertia(ig,islope),wice_inertia)
             stretch = (regolith_inertia(ig,islope)/wice_inertia)**2
             ice_table_thickness(ig,islope) = ice_table_thickness(ig,islope) + (ice_table_depth(ig,islope) - &
@@ -149 +149 @@
 !!!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-use comsoil_h_PEM,         only: mlayer_PEM
+use soil,         only: mlayer_PEM
 use comslope_mod,          only: subslope_dist, def_slope_mean
 use constants_marspem_mod, only: porosity
@@ -208 +208 @@
 !!!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-use comsoil_h_PEM, only: nsoilmx_PEM, mlayer_PEM
-use math_mod,      only: deriv1, deriv1_onesided, colint, findroot, deriv2_simple
+use soil, only: nsoilmx_PEM, mlayer_PEM
+use math_toolkit,  only: deriv1, deriv1_onesided, colint, findroot, deriv2_simple
 
 implicit none
@@ -379 +379 @@
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
-use comsoil_h_PEM, only: mlayer_PEM
-use abort_pem_mod, only: abort_pem
+use soil,      only: mlayer_PEM
+use stop_pem, only: stop_clean
 
 implicit none
@@ -395 +395 @@
 real, intent(out) :: Tice ! Ice temperatures (K)
 
-! Locals
-! ------
+! Local variables
+! ---------------
 integer :: ik       ! Loop variables
 integer :: indexice ! Index of the ice
@@ -417 +417 @@
     endif
     if (indexice < 0) then
-        call abort_pem("compute_Tice_pem","Subsurface ice is below the last soil layer!",1)
+        call stop_clean("compute_Tice_pem","Subsurface ice is below the last soil layer!",1)
     else
         if(indexice >= 1) then ! Linear inteprolation between soil temperature
@@ -439 +439 @@
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
-use abort_pem_mod, only: abort_pem
+use stop_pem, only: stop_clean
 
 implicit none
@@ -453 +453 @@
         rho = (1.72391 - 2.53e-4*T-2.87*1e-7*T**2)*1.e3 ! Mangan et al. 2017
     case default
-        call abort_pem("rho_ice","Type of ice not known!",1)
+        call stop_clean("rho_ice","Type of ice not known!",1)
 end select
 
 END FUNCTION rho_ice
 
-END MODULE ice_table_mod
+END MODULE ice_table