Changeset 3333

Timestamp:

May 17, 2024, 11:30:17 AM (7 months ago)

Author:

llange

Message:

Mars PCM
Fixing a bug in vdif_cd: a "residual", used as criterion to enter an iterative loop, was wrongly initialized. Hence, for some points, the algorithm does not go into the loop, and a wrong value of Cd, Ch was computed.
Also some cleaning/small fixing with save variables with OMP.

LL

Location:

trunk/LMDZ.MARS

Files:

• changelog.txt (modified) (1 diff)
• libf/phymars/conf_phys.F (modified) (1 diff)
• libf/phymars/paleoclimate_mod.F90 (modified) (1 diff)
• libf/phymars/vdif_cd_mod.F90 (modified) (3 diffs)

trunk/LMDZ.MARS/changelog.txt

@@ -4630 +4630 @@
 Some modifications in vdifc and pbl_parameters to include the effect of water buoyoncy on the sublimation of water ice.
 Note: it only works with paleoclimate = .true. (since the model is not tuned with that ...).
+
+== 17/05/2024 == LL
+Fixing a bug in vdif_cd: a "residual", used as criterion to enter an iterative loop, was wrongly initialized. Hence, for some points, the algorithm does not go into the loop, and a wrong value of Cd, Ch was computed.
+Also some cleaning/small fixing with save variables with OMP.

trunk/LMDZ.MARS/libf/phymars/conf_phys.F

@@ -376 +376 @@
          write(*,*)"albedo_perennialco2 = ",albedo_perennialco2
 
-         write(*,*)"Using lag layer??"
-         lag_layer=.false.
+         write(*,*)"Include water buoyancy effect??"
+         include_waterbuoyancy=.false.
          call getin_p("include_waterbuoyancy",include_waterbuoyancy)
          write(*,*) "include_waterbuoyancy = ", include_waterbuoyancy

trunk/LMDZ.MARS/libf/phymars/paleoclimate_mod.F90

@@ -20 +20 @@
     real,    save                              :: albedo_perennialco2     ! Albedo for perennial co2 ice [1]
     logical, save                              :: lag_layer               ! Does lag layer is present?
-    logical, save                              :: include_waterbuoyancy    ! Include the effect of water buoyancy when computing the sublimation of water ice ?
-!$OMP THREADPRIVATE(h2o_ice_depth,d_coef,lag_co2_ice,albedo_perennialco2,include_waterbuoyancy)
+    logical, save                              :: include_waterbuoyancy   ! Include the effect of water buoyancy when computing the sublimation of water ice ?
+!$OMP THREADPRIVATE(h2o_ice_depth,lag_co2_ice,d_coef,albedo_perennialco2,lag_layer,include_waterbuoyancy)
 
 !=======================================================================

trunk/LMDZ.MARS/libf/phymars/vdif_cd_mod.F90

@@ -157 +157 @@
       pcdh(:,:) = 0.
       z0t(:,:) = 0.
+      fm(:,:) = 0.
+      fh(:,:) = 0.
       f_ri_cd_min = 0.01
 ! this formulation assumes alphah=1., implying betah=betam
@@ -203 +205 @@
             DO ig=1,ngrid
                ite = 0.
-               residual = abs(pz0tcomp(ig)-pz0t) 
+               residual = 100*tol_iter*pz0(ig) 
                z1z0=pz(ig,1)/pz0(ig)
                cdn(ig)=karman/log(z1z0)
                cdn(ig)=cdn(ig)*cdn(ig)
-            
                DO WHILE((residual .gt. tol_iter*pz0(ig)) .and.  (ite .lt. itemax)) 
 ! Computations of z0T; iterated until z0T converges  
@@ -225 +226 @@
                       rib_dry(ig,islope) = ric_colaitis
                    ENDIF
-        
 ! Compute the stability functions fm; fh depending on the stability of the surface layer