Changeset 804

Timestamp:

Oct 10, 2012, 12:19:55 PM (12 years ago)

Author:

lkerber

Message:

A bug was found in gfluxi.F. If co2_ice was the only aerosol, the single scattering albedo was occasionally equal to 1. This led to NaNs? in gfluxi.F because we divide by a (1-W0) statement. Now there is a test in gfluxi.F which puts any W0=1 to W0=99999. This change removed the necessity in aeropacity.F90 for aerosols which are supposed to be zero to be put at 1.E-9 (they are now set to zero). In the case of zero aerosols, a dummy co2 aerosol is created and set to zero abundance everywhere. An obsolete test was removed from inifis.F. Some extraneous print statements were removed from physiq.F90.

Location:

trunk/LMDZ.GENERIC/libf/phystd

Files:

• aeropacity.F90 (modified) (1 diff)
• gfluxi.F (modified) (2 diffs)
• inifis.F (modified) (1 diff)
• physiq.F90 (modified) (7 diffs)
• suaer_corrk.F90 (modified) (1 diff)

trunk/LMDZ.GENERIC/libf/phystd/aeropacity.F90

@@ -137 +137 @@
             aerosol(1:ngrid,1:nlayermx,iaer)=0.0
 !       2. Opacity calculation
-            if (noaero) then ! aerosol set to a very low value
-             aerosol(1:ngrid,1:nlayermx,iaer)=1.e-9
+            if (noaero) then ! aerosol set to zero
+             aerosol(1:ngrid,1:nlayermx,iaer)=0.0
             elseif (aerofixco2.or.(i_co2ice.eq.0)) then !  CO2 ice cloud prescribed
                aerosol(1:ngrid,1:nlayermx,iaer)=1.e-9

trunk/LMDZ.GENERIC/libf/phystd/gfluxi.F

@@ -67 +67 @@
 
       DO L=1,L_NLAYRAD-1
+
+!----------------------------------------------------
+! There is a problem when W0 = 1
+!         open(888,file='W0')
+!           if ((W0(L).eq.0.).or.(W0(L).eq.1.)) then
+!             write(888,*) W0(L), L, 'gfluxi'
+!           endif
+! Prevent this with an if statement:
+        if (W0(L).eq.1.) then
+           W0(L) = 0.99999
+        endif
+!----------------------------------------------------
+
         ALPHA(L) = SQRT( (1.0-W0(L))/(1.0-W0(L)*COSBAR(L)) )
         LAMDA(L) = ALPHA(L)*(1.0-W0(L)*COSBAR(L))/UBARI
@@ -82 +95 @@
 
       L        = L_NLAYRAD
+
+      if (W0(L).eq.1.) then
+          W0(L) = 0.99999
+      end if
+
       ALPHA(L) = SQRT( (1.0-W0(L))/(1.0-W0(L)*COSBAR(L)) )
       LAMDA(L) = ALPHA(L)*(1.0-W0(L)*COSBAR(L))/UBARI

trunk/LMDZ.GENERIC/libf/phystd/inifis.F

@@ -449 +449 @@
          call getin("satval",satval)
          write(*,*)" satval = ",satval
-
-! Test of incompatibility:
-! if no tracers, then the variable aerosols should be turned off
-         if ((.not.tracer).and.(.not.aerofixco2)) then
-           print*,'if tracers are off, you must turn aerofixco2 on.'
-           print*, '(i.e., you must fix the aerosol distribution)'
-           print*, 'This option was formerly known as aerofixed'
-           stop
-         endif
-         if ((.not.tracer).and.(.not.aerofixh2o)) then
-           print*,'if tracers are off, you must turn aerofixh2o on.'
-           print*, '(i.e., you must fix the aerosol distribution)'
-           print*, 'This option was formerly known as aerofixed'
-           stop
-         endif
 
 

trunk/LMDZ.GENERIC/libf/phystd/physiq.F90

@@ -451 +451 @@
       if (firstcall) then
 
-         print*,'FIRSTCALL INITIALIZATION'
-
          !! this is defined in comsaison_h
          ALLOCATE(mu0(ngrid))
@@ -598 +596 @@
                             ! need epsi for the wvp definitions in callcorrk.F
 
-         print*,'end FIRSTCALL INITIALIZATION'
-
       endif        !  (end of "if firstcall")
 
@@ -605 +601 @@
 ! 1.2   Initializations done at every physical timestep:
 ! ---------------------------------------------------
-
-      print*,'ALL INITIALIZATION'
 
 !     Initialize various variables
@@ -660 +654 @@
          enddo
       enddo
-
-      print*,'end ALL INITIALIZATION'
 
 !-----------------------------------------------------------------------
@@ -828 +820 @@
 !-------------------------
 
-      print*,'end RADIATIVE TRANSFER'
       endif ! of if (callrad)
 
@@ -996 +987 @@
          !-------------------------
          
-      print*,'end CONVADJ'
       endif ! of if(calladj)
 
@@ -1008 +998 @@
             call abort
          endif
-     print*, 'we are in co2cond!!!!!'
          call condense_cloud(ngrid,nlayer,nq,ptimestep,   &
               capcal,pplay,pplev,tsurf,pt,                  &

trunk/LMDZ.GENERIC/libf/phystd/suaer_corrk.F90

@@ -101 +101 @@
 !     Please also choose the reference wavelengths of each aerosol
 
+      if (noaero) then
+        print*, 'naerkind= 0'
+      endif
       do iaer=1,naerkind
-       if (iaer.eq.iaero_co2)then
+       if (iaer.eq.iaero_co2) then
         forgetit=.true.
-        print*, 'naerkind= co2', iaer
-
+          if (.not.noaero) then
+              print*, 'naerkind= co2', iaer
+          end if
 !     visible
         if(forgetit)then