LMDZ.GENERIC. (Sorry for long text but this is a quite major commit)
Paving the path for parallel computations. And moving towards a more flexible code.
Automatic allocation is used within all routines in phystd. No further mention to ngridmx and nqmx.
- ngridmx and nqmx are still used in LMDZ.GENERIC in the dyn3d part
- if the LMDZ4/LMDZ5 dynamical core is used, there is no more fixed dimensions ngridmx and nqmx
--> a fully flexible parallel implementation is now possible (e.g. no need to recompile when changing numbers of processors)
The important stuff :
- Compilation checked with ifort. OK with and without debug mode. No errors.
Checked for: gcm, newstart, rcm1d, kcm1d
- RUN GCM: Running an Earth test case. Comparison with previous revision
--> debug mode : perfect match. bit by bit (diff command). checked with plots
--> O1 mode : close match (checked with plots)
--> O2 mode : sometimes up to 0.5 K departure....
BUT in this new version O2 and O1 are quite close while in previous version O1 and O2 differed by about, well, typically 0.5 K
(pictures available on request)
- RUN NEWSTART : perfect match (bit-by-bit) in either debug or normal mode.
- RUN RCM1D : perfect match in normal mode.
- RUN KCM1D : not tested (I don't know what is the use of kcm1d)
List of main changes :
- Additional arguments to some subroutines (ngrid and nq)
- F77 include strategy is obsolete and replaced by F90 module strategy
In this new strategy arrays are allocatable and allocated once at first use
This has to be done for all common featuring arrays defined with ngridmx or nqmx
surfdat.h >> surfdat_h.F90
tracer.h >> tracer_h.F90
comsaison.h >> comsaison_h.F90
comgeomfi.h >> comgeomfi_h.F90
comsoil.h >> comsoil_h.F90
comdiurn.h >> comdiurn_h.F90
fisice.h >> DELETED. was not used. probably a fossil.
watercap.h >> DELETED. variable put in surfdat_h.F90
- F77 'save' strategy is obsolete and replaced by F90 'allocatable save' strategy
(see previous point and e.g. new version of physiq.F90)
- Suppressing any mention to advtrac.h which is a common in the dynamics and needs nqmx
This was easily solved by adding an argument with tracer names, coming from the dynamics
This is probably not a definitive solution,
... but this allows for generic physics to work easily with either LMDZ.GENERIC or LMDZ dynamical cores
- Removing consistency tests between nq and nqmx ; and ngrid and ngridmx. No use now!
- Adaptation of rcm1d, kcm1d, newstart given above-mentioned changes
A note on phyetat0 and soil_setting:
- Now written so that a slice of horizontal size 'ngrid' starting at grid point 'cursor' is read in startfi.nc
'cursor' is defined in dimphys.h and initialized by inifis (or in newstart)
this is useful for parallel computations.
default behavior is the usual one : sequential runs, cursor is 1, size ngrid is the whole global domain
A note on an additional change :
- nueffrad is now an argument to callcorrk as is the case for reffrad
both are saved in physiq
this is for consistency and lisibility (previously nueffrad was saved in callcorrk)
... but there is a call to a function which modifies nueffrad in physiq
... previously this was not modifying nueffrad (although it was quite cumbersome to detect this)
... to be conservative I kept this behaviour and highlighted it with an array nueffrad_dummy
... I added a comment because someone might want to change this
