Changeset 4140 for trunk/LMDZ.COMMON/libf/evolution

Timestamp:

Mar 18, 2026, 1:56:02 PM (3 weeks ago)

Author:

jbclement

Message:

PEM:
Fix to avoid building large temporary arrays in the arguments evaluation of "compute_tendice" which caused memory to stall.
JBC

Location:

trunk/LMDZ.COMMON/libf/evolution

Files:

• changelog.txt (modified) (1 diff)
• pem.F90 (modified) (2 diffs)
• tendencies.F90 (modified) (3 diffs)

trunk/LMDZ.COMMON/libf/evolution/changelog.txt

@@ -927 +927 @@
 == 18/03/2026 == JBC
 Partial reversion of r4138: relocating "job_mod" to "LMDZ.COMMON/libf/misc/" because "parse_arg_mod" needs to know "job_mod" even if it is not the PEM.
+
+== 18/03/2026 == JBC
+Fix to avoid building large temporary arrays in the arguments evaluation of "compute_tendice" which caused memory to stall.

trunk/LMDZ.COMMON/libf/evolution/pem.F90

@@ -210 +210 @@
 allocate(d_h2oice(ngrid,nslope),d_co2ice(ngrid,nslope))
 call print_msg('> Computing surface ice tendencies',LVL_NFO)
-call compute_tendice(minPCM_h2operice + minPCM_h2ofrost,h2o_ice(:,:) > 0._dp,d_h2oice)
+call compute_tendice(minPCM_h2operice,minPCM_h2ofrost,h2o_ice,d_h2oice)
 call print_msg('H2O ice tendencies [kg/m2/yr] (min|max): '//real2str(minval(d_h2oice))//' | '//real2str(maxval(d_h2oice)),LVL_NFO)
-call compute_tendice(minPCM_co2perice + minPCM_co2frost,co2_ice(:,:) > 0._dp,d_co2ice)
+call compute_tendice(minPCM_co2perice,minPCM_co2frost,co2_ice,d_co2ice)
 call print_msg('CO2 ice tendencies [kg/m2/yr] (min|max): '//real2str(minval(d_co2ice))//' | '//real2str(maxval(d_co2ice)),LVL_NFO)
 deallocate(minPCM_h2operice,minPCM_co2perice,minPCM_h2ofrost,minPCM_co2frost)
@@ -433 +433 @@
 
     ! Save periodic backups of restart files
-    if (backup_rate > 0 .and. mod(idt,backup_rate) == 0) then
-        call save_clim_state(h2o_ice,co2_ice,tsurf_avg,tsurf_dev,tsoil_avg,tsoil_dev,ps_avg,ps_dev,ps_avg_glob,ps_avg_glob_ini, &
-                             icetable_depth,icetable_thickness,ice_porefilling,h2o_ads_reg,co2_ads_reg,layerings_map,idt)
+    if (backup_rate > 0) then
+        if (mod(idt,backup_rate) == 0) call save_clim_state(h2o_ice,co2_ice,tsurf_avg,tsurf_dev,tsoil_avg,tsoil_dev,ps_avg,ps_dev,ps_avg_glob,ps_avg_glob_ini, &
+                                                            icetable_depth,icetable_thickness,ice_porefilling,h2o_ads_reg,co2_ads_reg,layerings_map,idt)
     end if
 

trunk/LMDZ.COMMON/libf/evolution/tendencies.F90

@@ -28 +28 @@
 
 !=======================================================================
-SUBROUTINE compute_tendice(min_ice,is_perice,d_ice)
+SUBROUTINE compute_tendice(min_perice,min_frost,perice,d_ice)
 !-----------------------------------------------------------------------
 ! NAME
@@ -51 +51 @@
 ! ARGUMENTS
 ! ---------
-real(dp),    dimension(:,:,:), intent(in)  :: min_ice
-logical(k4), dimension(:,:),   intent(in)  :: is_perice
-real(dp),    dimension(:,:),   intent(out) :: d_ice
+real(dp), dimension(:,:,:), intent(in)  :: min_perice
+real(dp), dimension(:,:,:), intent(in)  :: min_frost
+real(dp), dimension(:,:),   intent(in)  :: perice
+real(dp), dimension(:,:),   intent(out) :: d_ice
 
 ! CODE
 ! ----
 ! We compute the difference to get the tendency
-d_ice(:,:) = min_ice(:,:,2) - min_ice(:,:,1)
+d_ice(:,:) = min_perice(:,:,2) + min_frost(:,:,2) - (min_perice(:,:,1) + min_frost(:,:,1))
 
 ! If the difference is too small, then there is no evolution
@@ -64 +65 @@
 
 ! If the tendency is negative but there is no ice reservoir for the PEM
-where (abs(d_ice) < 0._dp .and. .not. is_perice) d_ice = 0._dp
+where (d_ice < 0._dp .and. abs(perice) < minieps) d_ice = 0._dp
 
 END SUBROUTINE compute_tendice