Changeset 3366

Timestamp:

Jun 11, 2024, 3:12:31 PM (6 months ago)

Author:

llange

Message:

Mars PEM
Fixing bug in the initial computation of ice tendencies (a negative tendancies was computed when a glacier was disapearing at the end of the second year of the PCM).
Fixing a bug in the update of the tendencies of CO2 to ensure mass conservation
LL

Location:

trunk/LMDZ.COMMON/libf/evolution

Files:

• changelog.txt (modified) (1 diff)
• compute_tend_mod.F90 (modified) (2 diffs)
• evol_ice_mod.F90 (modified) (1 diff)

trunk/LMDZ.COMMON/libf/evolution/changelog.txt

@@ -349 +349 @@
 Some features might not work very well yet since not every stituation has not been tested.
 
-== 10/06/2024 == JBC
-- The PEM can now stop itself cleanly before the SLURM time limit for the job is reached and it continues the simulation with a new cycle.
-- Update of "jobPEM.slurm" in the deftank to guarantee enough memory space to run the job.
-- Few minor cleanings.
-
-== 10/06/2024 == JBC
-Correction of an error in "lib_launchPEM.sh" due to a miscalculated condition + Improvement of the relaunch which now cleans the unnecessary files.
+== 11/06/2024 == LL
+Fixing bug in the initial computation of ice tendencies (a negative tendancies was computed when a glacier was disapearing at the end of the second year of the PCM).
+Fixing a bug in the update of the tendencies of CO2 to ensure mass conservation
+
+~                

trunk/LMDZ.COMMON/libf/evolution/compute_tend_mod.F90

@@ -13 +13 @@
 !=======================================================================
 !
-! Compute the tendencies of the evolution of water ice over the years
+! Compute the initial tendencies of the evolution ice based on the PCM data
 !
 !=======================================================================
@@ -33 +33 @@
 where (abs(tendencies_ice) < 1.e-10) tendencies_ice = 0.
 
+! If the minimum over the last year is 0 then we have no perennial ice
+where (abs(min_ice(:,:,2)) < 1.e-10) tendencies_ice = 0.
 END SUBROUTINE compute_tend
 

trunk/LMDZ.COMMON/libf/evolution/evol_ice_mod.F90

@@ -29 +29 @@
 !   local:
 !   ------
-
+real, dimension(ngrid,nslope) ::                co2_ice_tmp  ! Evolution of perennial ice over one year
 !=======================================================================
 ! Evolution of CO2 ice for each physical point
 write(*,*) 'Evolution of co2 ice'
-co2_ice = co2_ice + tend_co2_ice*dt_pem
-where (co2_ice < 0.)
-    co2_ice = 0.
-    tend_co2_ice = 0.
+co2_ice_tmp = co2_ice + tend_co2_ice*dt_pem
+where (co2_ice_tmp < 0.)
+    co2_ice_tmp = 0.
+    tend_co2_ice = -co2_ice/dt_pem
 end where
-
+co2_ice = co2_ice_tmp
 END SUBROUTINE evol_co2_ice