Changeset 2570

Timestamp:

Oct 22, 2021, 5:23:36 PM (3 years ago)

Author:

emillour

Message:

Mars GCM:
Improve tests by "check_physics_fields": also look for
negative values of tracers.
EM

Location:

trunk/LMDZ.MARS

Files:

• README (modified) (1 diff)
• libf/phymars/check_fields.F90 (modified) (8 diffs)
• libf/phymars/physiq_mod.F (modified) (2 diffs)

trunk/LMDZ.MARS/README

@@ -3485 +3485 @@
 else
   zcondicea, zfallice
+
+== 22/10/2021 == EM
+Improve tests by "check_physics_fields": also look for
+negative values of tracers.

trunk/LMDZ.MARS/libf/phymars/check_fields.F90

@@ -11 +11 @@
 contains
 
-subroutine check_physics_fields(message,temp,u,v,pplev)
-use dimphy, only: klon, klev
-implicit none
-character(len=*),intent(in):: message 
+subroutine check_physics_fields(message,temp,u,v,pplev,q)
+use dimphy, only: klon, klev
+use tracer_mod, only: nqmx
+implicit none
+character(len=*),intent(in):: message ! text message for outputs
 real,intent(in) :: temp(klon,klev)
 real,intent(in) :: u(klon,klev) ! zonal wind (m/s)
 real,intent(in) :: v(klon,klev) ! meridional wind (m/s)
 real,intent(in) :: pplev(klon,klev+1) ! pressure at level interfaces (Pa)
+real,intent(in) :: q(klon,klev,nqmx) ! tracer mixing ratio (.../kg_air)
 
 character(len=50) :: name="check_physics_fields"
-logical ok_t,ok_w,ok_ps
+logical :: ok_t,ok_w,ok_ps,ok_q
 
 ! 1. Initialisations
-ok_t=.true.
-ok_w=.true.
-ok_ps=.true.
+ok_q=.true.
 
 ! 2. Check temperature, winds and surface pressure
-call check_temperature(temp,ok_t)
-call check_winds(u,v,ok_w)
-call check_ps(pplev(:,1),ok_ps)
-
-if ((.not.ok_t).or.(.not.ok_w).or.(.not.ok_ps)) then
+call check_temperature(message,temp,ok_t)
+call check_winds(message,u,v,ok_w)
+call check_ps(message,pplev(:,1),ok_ps)
+if (nqmx>=1) then
+  call check_tracers(message,q,ok_q)
+endif
+
+if ((.not.ok_t).or.(.not.ok_w).or.(.not.ok_ps).or.(.not.ok_q)) then
   ! Something is wrong, might as well stop here
   call abort_physic(trim(name),trim(message)//" Invalid field values",1)
@@ -41 +44 @@
 
 
-subroutine check_temperature(temp,ok,temp_min,temp_max)
-use dimphy, only: klon, klev
-implicit none
+subroutine check_temperature(message,temp,ok,temp_min,temp_max)
+use dimphy, only: klon, klev
+implicit none
+character(len=*),intent(in):: message ! text message for outputs
 real,intent(in) :: temp(klon,klev)
 logical,intent(out) :: ok ! returns .true. if everything OK, .false. otherwise
@@ -75 +79 @@
     if (temp(i,k).ne.temp(i,k)) then
       ok=.false.
-      write(*,*)trim(name)//" temp(i,k)=",temp(i,k)," for i=",i," k=",k
+      write(*,*)trim(message)//" "//trim(name)//" temp(i,k)=",temp(i,k),&
+                " for i=",i," k=",k
     endif
     ! check for temperatures too low
     if (temp(i,k).lt.tmin) then
       ok=.false.
-      write(*,*)trim(name)//" temp(i,k)=",temp(i,k)," for i=",i," k=",k,&
-      "<",tmin
+      write(*,*)trim(message)//" "//trim(name)//" temp(i,k)=",temp(i,k),&
+      " for i=",i," k=",k," <",tmin
     endif
     ! check for temperatures too high
     if (temp(i,k).gt.tmax) then
       ok=.false.
-      write(*,*)trim(name)//" temp(i,k)=",temp(i,k)," for i=",i," k=",k,&
-      ">",tmax
+      write(*,*)trim(message)//" "//trim(name)//" temp(i,k)=",temp(i,k),&
+      " for i=",i," k=",k," >",tmax
     endif
   enddo
@@ -94 +99 @@
 end subroutine check_temperature
 
-subroutine check_winds(u,v,ok,wind_max)
-use dimphy, only: klon, klev
-implicit none
+subroutine check_winds(message,u,v,ok,wind_max)
+use dimphy, only: klon, klev
+implicit none
+character(len=*),intent(in):: message ! text message for outputs
 real,intent(in) :: u(klon,klev) ! zonal wind (m/s)
 real,intent(in) :: v(klon,klev) ! meridional wind (m/s)
@@ -123 +129 @@
     if (u(i,k).ne.u(i,k)) then
       ok=.false.
-      write(*,*)trim(name)//" u(i,k)=",u(i,k)," for i=",i," k=",k
+      write(*,*)trim(message)//" "//trim(name)//" u(i,k)=",u(i,k),&
+      " for i=",i," k=",k
     endif
     if (v(i,k).ne.v(i,k)) then
       ok=.false.
-      write(*,*)trim(name)//" v(i,k)=",v(i,k)," for i=",i," k=",k
+      write(*,*)trim(message)//" "//trim(name)//" v(i,k)=",v(i,k),&
+      " for i=",i," k=",k
     endif
     ! check for magnitudes too high
     if (abs(u(i,k)).gt.wmax) then
       ok=.false.
-      write(*,*)trim(name)//" u(i,k)=",u(i,k)," for i=",i," k=",k,&
-      ">",wmax
+      write(*,*)trim(message)//" "//trim(name)//" u(i,k)=",u(i,k),&
+      " for i=",i," k=",k," >",wmax
     endif
     if (abs(v(i,k)).gt.wmax) then
       ok=.false.
-      write(*,*)trim(name)//" v(i,k)=",v(i,k)," for i=",i," k=",k,&
-      ">",wmax
+      write(*,*)trim(message)//" "//trim(name)//" v(i,k)=",v(i,k),&
+      " for i=",i," k=",k," >",wmax
     endif
   enddo
@@ -145 +153 @@
 end subroutine check_winds
 
-subroutine check_ps(ps,ok,ps_min,ps_max)
+subroutine check_ps(message,ps,ok,ps_min,ps_max)
 use dimphy, only: klon
 implicit none
+character(len=*),intent(in):: message ! text message for outputs
 real,intent(in) :: ps(klon)
 logical,intent(out) :: ok ! returns .true. if everything OK, .false. otherwise
@@ -178 +187 @@
   if (ps(i).ne.ps(i)) then
     ok=.false.
-    write(*,*)trim(name)//" ps(i)=",ps(i)," for i=",i
+    write(*,*)trim(message)//" "//trim(name)//" ps(i)=",ps(i)," for i=",i
   endif
   ! check for pressures too low
   if (ps(i).lt.pmin) then
     ok=.false.
-    write(*,*)trim(name)//" ps(i)=",ps(i)," for i=",i,"<",pmin
+    write(*,*)trim(message)//" "//trim(name)//" ps(i)=",ps(i)," for i=",i,&
+    " <",pmin
   endif
   ! check for pressures too high
   if (ps(i).gt.pmax) then
     ok=.false.
-    write(*,*)trim(name)//" ps(i)=",ps(i)," for i=",i,">",pmax
+    write(*,*)trim(message)//" "//trim(name)//" ps(i)=",ps(i)," for i=",i,&
+    " >",pmax
   endif
 enddo
@@ -194 +205 @@
 end subroutine check_ps
 
+subroutine check_tracers(message,q,ok)
+use dimphy, only: klon, klev
+use tracer_mod, only: nqmx,noms
+implicit none
+character(len=*),intent(in):: message ! text message for outputs
+real,intent(in) :: q(klon,klev,nqmx) ! tracer mixing ratio
+logical,intent(inout) :: ok ! set to .false. if something is wrong
+
+character(len=50) :: name="check_tracers"
+integer :: i,k,iq
+integer :: nb_bad_neg ! number of problematic points (negative values)
+integer :: nb_bad_nan ! number of problematic points (NaNs)
+
+! 1. initializations
+nb_bad_nan=0
+
+! 2. do the checking
+do iq=1,nqmx
+ nb_bad_neg=0 ! initialize
+ do i=1,klon
+  do k=1,klev
+    ! look for NaN
+    if (q(i,k,iq).ne.q(i,k,iq)) then
+      ok=.false.
+      nb_bad_nan=nb_bad_nan+1
+    endif
+    ! look for negative values
+    if (q(i,k,iq).lt.0) then
+!      ok=.false.
+      nb_bad_neg=nb_bad_neg+1
+    endif
+  enddo
+ enddo
+ if (nb_bad_neg>0) then
+   write(*,*)trim(message)//" "//trim(name)//" tracer "//trim(noms(iq))//&
+   " contains ",nb_bad_neg," negative values!"
+ endif
+enddo !of do iq=1,nqmx
+
+end subroutine check_tracers
+
 end module check_fields_mod

trunk/LMDZ.MARS/libf/phymars/physiq_mod.F

@@ -743 +743 @@
       if (check_physics_inputs) then
         ! Check the validity of input fields coming from the dynamics
-        call check_physics_fields("begin physiq:",pt,pu,pv,pplev)
+        call check_physics_fields("begin physiq:",pt,pu,pv,pplev,pq)
       endif
 
@@ -3978 +3978 @@
       if (check_physics_outputs) then
         ! Check the validity of updated fields at the end of the physics step
-        call check_physics_fields("end of physiq:",zt,zu,zv,zplev)
+        call check_physics_fields("end of physiq:",zt,zu,zv,zplev,zq)
       endif