Changeset 2109

Timestamp:

Mar 4, 2019, 4:03:08 PM (6 years ago)

Author:

jvatant

Message:

Fix some problems for the microphysics :
+ Altitude of the last level at 1e7m from physics was certainly source of divergence
+ Sanity check for negative is moved from within mm_microphysic to the end of calmufi avoiding rounding pbs
--JVO

Location:

trunk/LMDZ.TITAN

Files:

• README (modified) (1 diff)
• libf/muphytitan/mm_haze.f90 (modified) (1 diff)
• libf/muphytitan/mm_microphysic.f90 (modified) (3 diffs)
• libf/phytitan/calmufi.F90 (modified) (3 diffs)
• libf/phytitan/physiq_mod.F90 (modified) (2 diffs)

trunk/LMDZ.TITAN/README

@@ -1552 +1552 @@
 Fix a problem of interoperability C-Fortran for picky compilers.
 Using iso_c_binding could be a smart future improvement to bring.
+
+== 04/03/19 == JVO (r2109)
+Fix some problems for the microphysics :
++ Altitude of the last level at 1e7m from physics was certainly source of divergence
++ Sanity check for negative is moved from within mm_microphysic to the end of calmufi avoiding rounding pbs

trunk/LMDZ.TITAN/libf/muphytitan/mm_haze.f90

@@ -126 +126 @@
     IF (mm_w_haze_prod) THEN
       call mm_haze_production(zdm0as,zdm3as)
-      ! We only produce fractal aerosols
+      ! We only produce spherical aerosols
       dm0a_s=dm0a_s+zdm0as ; dm3a_s=dm3a_s+zdm3as 
     ENDIF

trunk/LMDZ.TITAN/libf/muphytitan/mm_microphysic.f90

@@ -111 +111 @@
       ! add temporary aerosols tendencies (-> m-3)
       dm0a_f = dm0a_f + zdm0a_f  ; dm3a_f = dm3a_f + zdm3a_f
-      ! reverse directly clouds tendencies (-> m-2)
+      ! reverse clouds tendencies (-> m-2)
       dm0n   = dm0n(mm_nla:1:-1) * mm_dzlev(mm_nla:1:-1)
       dm3n   = dm3n(mm_nla:1:-1) * mm_dzlev(mm_nla:1:-1)
-      ! sanity check for clouds tendencies
-      WHERE (mm_m0ccn+dm0n < 0) ; dm0n = -mm_m0ccn ; END WHERE
-      WHERE (mm_m3ccn+dm3n < 0) ; dm3n = -mm_m3ccn ; END WHERE
       DO i=1,mm_nesp
         dm3i(:,i)  = dm3i(mm_nla:1:-1,i)  * mm_dzlev(mm_nla:1:-1)
-        WHERE (mm_m3ice+dm3i < 0) ; dm3i = -mm_m3ice ; END WHERE
         dgazs(:,i) = dgazs(mm_nla:1:-1,i) 
-        ! no sanity check for gazs, let's prey.
       ENDDO
     ELSE
@@ -131 +126 @@
     dm0a_f = dm0a_f(mm_nla:1:-1) * mm_dzlev(mm_nla:1:-1)
     dm3a_f = dm3a_f(mm_nla:1:-1) * mm_dzlev(mm_nla:1:-1)
-    ! sanity check
-    WHERE (mm_m0aer_s+dm0a_s < 0) ; dm0a_s = -mm_m0aer_s ; END WHERE
-    WHERE (mm_m3aer_s+dm3a_f < 0) ; dm3a_s = -mm_m3aer_s ; END WHERE
-    WHERE (mm_m0aer_f+dm0a_f < 0) ; dm0a_f = -mm_m0aer_f ; END WHERE
-    WHERE (mm_m3aer_f+dm3a_f < 0) ; dm3a_f = -mm_m3aer_f ; END WHERE
     
     RETURN
@@ -170 +160 @@
     dm0a_f = dm0a_f(mm_nla:1:-1) * mm_dzlev(mm_nla:1:-1) 
     dm3a_f = dm3a_f(mm_nla:1:-1) * mm_dzlev(mm_nla:1:-1)
-    ! sanity check
-    WHERE (mm_m0aer_s+dm0a_s < 0) ; dm0a_s = -mm_m0aer_s ; END WHERE
-    WHERE (mm_m3aer_s+dm3a_f < 0) ; dm3a_s = -mm_m3aer_s ; END WHERE
-    WHERE (mm_m0aer_f+dm0a_f < 0) ; dm0a_f = -mm_m0aer_f ; END WHERE
-    WHERE (mm_m3aer_f+dm3a_f < 0) ; dm3a_f = -mm_m3aer_f ; END WHERE
     RETURN
   END FUNCTION muphys_nocld

trunk/LMDZ.TITAN/libf/phytitan/calmufi.F90

@@ -31 +31 @@
   REAL(kind=8), DIMENSION(:,:), INTENT(IN) :: temp  !! Temperature at the center of each layer (K).
 
-  REAL(kind=8), DIMENSION(:,:,:), INTENT(IN)  :: pq    !! Tracers (\(kg.kg^{-1}}\)).
-  REAL(kind=8), DIMENSION(:,:,:), INTENT(IN)  :: zdqfi !! Tendency from former processes for tracers (\(kg.kg^{-1}}\)).
-  REAL(kind=8), DIMENSION(:,:,:), INTENT(OUT) :: zdq   !! Microphysical tendency for tracers (\(kg.kg^{-1}}\)).
+  REAL(kind=8), DIMENSION(:,:,:), INTENT(IN)  :: pq    !! Tracers (\(X.kg^{-1}}\)).
+  REAL(kind=8), DIMENSION(:,:,:), INTENT(IN)  :: zdqfi !! Tendency from former processes for tracers (\(X.kg^{-1}}\)).
+  REAL(kind=8), DIMENSION(:,:,:), INTENT(OUT) :: zdq   !! Microphysical tendency for tracers (\(X.kg^{-1}}\)).
   
-  REAL(kind=8), DIMENSION(:,:,:), ALLOCATABLE :: zq !! Local tracers updated from former processes (\(kg.kg^{-1}}\)).
+  REAL(kind=8), DIMENSION(:,:,:), ALLOCATABLE :: zq !! Local tracers updated from former processes (\(X.kg^{-1}}\)).
   
   REAL(kind=8), DIMENSION(:), ALLOCATABLE :: m0as !! 0th order moment of the spherical mode (\(m^{-2}\)).
@@ -56 +56 @@
   REAL(kind=8), DIMENSION(:,:), ALLOCATABLE :: dgazs !! Tendencies of each condensible gaz species !(\(mol.mol^{-1}\)). 
 
-  REAL(kind=8), DIMENSION(:,:), ALLOCATABLE ::  int2ext
+  REAL(kind=8), DIMENSION(:,:), ALLOCATABLE ::  int2ext !! (\(m^{-2}\)).
   TYPE(error) :: err
 
@@ -165 +165 @@
       enddo
     endif
+
+    ! Sanity check ( way safer to be done here rather than within YAMMS )
+    WHERE (zq+zdq < 0.0) ; zdq = -zq ; END WHERE
+
   END DO ! loop on ilon
 

trunk/LMDZ.TITAN/libf/phytitan/physiq_mod.F90

@@ -1082 +1082 @@
  
          if (callmufi) then
+            zzlev(:,nlayer+1)=zzlay(:,nlayer)+(zzlay(:,nlayer)-zzlev(:,nlayer)) ! JVO 19 : We assume zzlev isn't reused later on
 #ifdef USE_QTEST
             dtpq(:,:,:) = 0.0 ! we want tpq to go only through mufi
@@ -1087 +1088 @@
             tpq(:,:,:) = tpq(:,:,:) + zdqmufi(:,:,:)*ptimestep ! only manipulation of tpq->*ptimestep here
 #else
-            call calmufi(ptimestep,pplev,zzlev,pplay,zzlay,gzlat,pt,pq,pdq,zdqmufi) ! JVO 19 : To be fixed, what altitude do we need ?
+            call calmufi(ptimestep,pplev,zzlev,pplay,zzlay,gzlat,pt,pq,pdq,zdqmufi)
             pdq(:,:,:) = pdq(:,:,:) + zdqmufi(:,:,:)
 #endif