Changeset 5650

Timestamp:

May 13, 2025, 5:41:30 PM (4 weeks ago)

Author:

dcugnet

Message:

Bug fix: Coriolis parameters should be computed for each task and not broadcasted from the master.

File:

• LMDZ6/trunk/libf/phylmd/tropopause_m.f90 (modified) (4 diffs)

LMDZ6/trunk/libf/phylmd/tropopause_m.f90

@@ -22 +22 @@
   USE assert_eq_m,  ONLY: assert_eq
   USE dimphy,       ONLY: klon, klev
-  USE geometry_mod, ONLY: latitude_deg, longitude_deg
+  USE geometry_mod, ONLY: latitude
   USE strings_mod,  ONLY: maxlen
-  USE yomcst_mod_h, ONLY: ROMEGA, RPI, RKAPPA, RG
+  USE yomcst_mod_h, ONLY: ROMEGA, RKAPPA, RG
   USE vertical_layers_mod,    ONLY: aps, bps, preff
   USE lmdz_reprobus_wrappers, ONLY: itroprep
@@ -76 +76 @@
   IF(lFirst) THEN
      ALLOCATE(fac(klon), w(ns+1, ns+1))
+
+     !--- COMPUTE THE CORIOLIS PARAMETER FOR PV ALCULATION ROUTINE "potentialVorticity"
+     DO i = 1, klon
+        fac(i) = 2. * ROMEGA * SIN(latitude(i))
+     END DO
 !$OMP BARRIER
+
      IF(is_master) THEN
 
@@ -82 +88 @@
        !--- NOTE: "k0" DEPENDS ON VERTICAL DISCRETIZATION ONLY (VIA HYBRID COEFFS aps, bps) AND IS NOT SIMULATION-DEPENDENT
         DO k0 = 1, klev; IF( aps(k0) / preff + bps(k0) < sg0 ) EXIT; END DO     !--- START INDEX FOR BOTTOM->TOP PV SEARCH LOOP
-
-        !--- COMPUTE THE CORIOLIS PARAMETER FOR PV ALCULATION ROUTINE "potentialVorticity"
-        DO i = 1, klon
-           fac(:) = 2. * ROMEGA * SIN(latitude_deg(:) * RPI/180.)
-        END DO
 
         !--- COMPUTE THE WEIGHTS FOR THE VERTICAL SMOOTHING ROUTINE "smooth"
@@ -100 +101 @@
      END IF
      CALL bcast(k0)
-     CALL bcast(fac)
      CALL bcast(w)
      CALL bcast(lFirst)