Changeset 5081 for LMDZ6/branches/Amaury_dev/libf/dyn3d_common

Timestamp:

Jul 19, 2024, 4:15:44 PM (5 months ago)

Author:

abarral

Message:

Commit linked to correcting relevant warnings during gfortran compilation

[minor]
Correct remnants of fixed-form "+" in massbarxy.F90
Correct COMMON alignment in clesphys.h, flux_arp.h, cv*param.h, YOECUMF.h, alpale.h
Correct obsolete logical operators
Restrict use of iso_fortran_env in nf95_abort.f90
Remove redundant save in module declarations
Remove <continue> without labels
Fix nonstandard kind selectors

Location:

LMDZ6/branches/Amaury_dev/libf/dyn3d_common

Files:

• limy.F (modified) (3 diffs)
• massbarxy.F90 (modified) (1 diff)

LMDZ6/branches/Amaury_dev/libf/dyn3d_common/limy.F

@@ -150 +150 @@
 c      enddo
 
-      if(dyqv(ismin(iim,dyqv,1))*dyqv(ismax(iim,dyqv,1)).le.0.)
+      if(dyqv(ismin(iim,dyqv,1))*dyqv(ismax(iim,dyqv,1))<=0.)
      &   then
          do ij=1,iip1
@@ -162 +162 @@
 
       if(dyqv(ismax(iim,dyqv(ip1jm-iip1+1),1)+ip1jm-iip1+1)*
-     & dyqv(ismin(iim,dyqv(ip1jm-iip1+1),1)+ip1jm-iip1+1).le.0.)
+     & dyqv(ismin(iim,dyqv(ip1jm-iip1+1),1)+ip1jm-iip1+1)<=0.)
      &then
          do ij=ip1jm+1,ip1jmp1
@@ -175 +175 @@
 c   calcul des pentes limitees
 
-      do ij=1,ip1jmp1
-         if(dyqv(ij)*dyqv(ij-iip1).gt.0.) then
+      do ij=1,ip1jmp1 ! cf below: should it be ip1jm instead ?
+         if(dyqv(ij)*dyqv(ij-iip1)>0.) then  ! /!\ causes Warning: iteration 1056 invokes undefined behavior [-Waggressive-loop-optimizations] in 32x32x39
             dyq(ij)=sign(min(abs(dyq(ij)),dyqmax(ij)),dyq(ij))
          else

LMDZ6/branches/Amaury_dev/libf/dyn3d_common/massbarxy.F90

@@ -21 +21 @@
     DO ij=1,ip1jm-1
       massebxy(ij,l)=masse(ij     ,l)*alpha2(ij     ) + &
-     +               masse(ij+1   ,l)*alpha3(ij+1   ) + &
-     +               masse(ij+iip1,l)*alpha1(ij+iip1) + &
-     +               masse(ij+iip2,l)*alpha4(ij+iip2)
+                     masse(ij+1   ,l)*alpha3(ij+1   ) + &
+                     masse(ij+iip1,l)*alpha1(ij+iip1) + &
+                     masse(ij+iip2,l)*alpha4(ij+iip2)
     END DO
     DO ij=iip1,ip1jm,iip1; massebxy(ij,l)=massebxy(ij-iim,l); END DO