Changeset 4755

Timestamp:

Nov 22, 2023, 3:46:17 PM (6 months ago)

Author:

lebasn

Message:

Methox: Update comments to correct units + bugfix on output variable

Location:

LMDZ6/trunk/libf

Files:

• phylmd/StratAer/stratH2O_methox.F90 (modified) (5 diffs)
• phylmd/phys_output_write_mod.F90 (modified) (1 diff)
• phylmd/physiq_mod.F90 (modified) (3 diffs)
• phylmdiso/physiq_mod.F90 (modified) (2 diffs)

LMDZ6/trunk/libf/phylmd/StratAer/stratH2O_methox.F90

@@ -4 +4 @@
 SUBROUTINE stratH2O_methox(debutphy,paprs,dq_ch4mmr)
 !
-! output: CH4VMR in mmr (mass mixing ratio/sec: kg H2O/kg air)
+! output: CH4VMR in MMR/s (mass mixing ratio/s or kg H2O/kg air/s)
 
   USE netcdf95, ONLY: nf95_close, nf95_gw_var, nf95_inq_dimid, & 
@@ -26 +26 @@
   include "dimensions.h"
   
-! Variable input
+! Input variables
   REAL paprs(klon,klev+1)
-  LOGICAL, INTENT(IN) :: debutphy   ! le flag de l'initialisation de la physique
-! Variable output
-! tendance buffer pour appel de add_phys_tend
+  LOGICAL, INTENT(IN) :: debutphy   ! flag for first physiq step
+! Output variables
+! tendency buffer used in add_phys_tend subroutine (in physiq_mod)
   REAL, INTENT(INOUT), DIMENSION(klon,klev)  :: dq_ch4mmr
   
-! Variables locales
+! Local variables
   INTEGER n_lat   ! number of latitudes in the input data
   INTEGER n_lon   ! number of longitudes in the input data
@@ -42 +42 @@
 !$OMP THREADPRIVATE(mth_pre)
   
-! Champs reconstitues
+! Reconstitutes fields
   REAL paprs_glo(klon_glo,klev+1)
   
@@ -54 +54 @@
 ! levels of input data
   
-!stratospheric H2O source from CH4 oxidation
-! fixed climatos
-! H2O production in VMR/sec)
+! Stratospheric H2O source from CH4 oxidation from fixed climatos
+! (H2O production in VMR/sec)
   REAL, ALLOCATABLE :: CH4RVMR_in(:, :, :, :)
   REAL, ALLOCATABLE :: CH4RVMR_mth(:, :, :)
@@ -122 +121 @@
         !---correct latitudinal order,convert input from volume mixing ratio to mass mixing ratio
         DO j=1,n_lat
-           ! convert VMR/sec in mmr (mass mixing ratio/sec: kg H2O/kg air)
+           ! convert VMR/s in MMR/s (mass mixing ratio/s or kg H2O/kg air/s)
            ! x2 because CH4->2*H2O
            CH4RVMR_mth(:,j,:) = 2*CH4RVMR_in(:,n_lat+1-j,:,mth_cur)*mH2Omol/mAIRmol

LMDZ6/trunk/libf/phylmd/phys_output_write_mod.F90

@@ -2260 +2260 @@
 
        IF (ok_qch4) THEN
-          IF (vars_defined) zx_tmp_fi3d=d_q_ch4 / pdtphys
+          IF (vars_defined) zx_tmp_fi3d=d_q_ch4
           CALL histwrite_phy(o_dqch4, zx_tmp_fi3d)
        ENDIF

LMDZ6/trunk/libf/phylmd/physiq_mod.F90

@@ -5025 +5025 @@
     !DC Calcul de la tendance due au methane
     IF (ok_qch4) THEN
-!      d_q_ch4: H2O source in ppmv/sec
+!      d_q_ch4: H2O source from CH4 in MMR/s (mass mixing ratio/s or kg H2O/kg air/s)
 #ifdef CPP_StratAer
        CALL stratH2O_methox(debut,paprs,d_q_ch4)
 #else
-!      ecmwf routine METHOX
+!      ECMWF routine METHOX
        CALL METHOX(1,klon,klon,klev,q_seri,d_q_ch4,pplay)
 #endif
-       ! ajout de la tendance d'humidite due au methane
+       ! add humidity tendency due to methane
        d_q_ch4_dtime(:,:) = d_q_ch4(:,:)*phys_tstep
        CALL add_phys_tend(du0, dv0, dt0, d_q_ch4_dtime, dql0, dqi0, dqbs0, paprs, &
             'q_ch4', abortphy,flag_inhib_tend,itap,0)
-       d_q_ch4(:,:) = d_q_ch4_dtime(:,:)/phys_tstep
+       d_q_ch4(:,:) = d_q_ch4_dtime(:,:)/phys_tstep ! update with H2O conserv done in add_phys_tend
     ENDIF
     !
@@ -5050 +5050 @@
        
        SELECT CASE(flag_emit)
-       CASE(1) ! emission volc H2O dans LMDZ
+       CASE(1) ! emission volc H2O in LMDZ
           DO ieru=1, nErupt
              IF (year_cur==year_emit_vol(ieru).AND.&
@@ -5058 +5058 @@
                 
                 IF(flag_verbose_strataer) print *,'IN physiq_mod: date=',year_cur,mth_cur,day_cur
-                ! initialisation tendance q emission
+                ! initialisation of q tendency emission
                 d_q_emiss(:,:)=0.
                 ! daily injection mass emission - NL

LMDZ6/trunk/libf/phylmdiso/physiq_mod.F90

@@ -6196 +6196 @@
     !DC Calcul de la tendance due au methane
     IF (ok_qch4) THEN
-!      d_q_ch4: H2O source in ppmv/sec
+!      d_q_ch4: H2O source from CH4 in MMR/s (mass mixing ratio/s or kg H2O/kg air/s)
 #ifdef CPP_StratAer
        CALL stratH2O_methox(debut,paprs,d_q_ch4)
 #else
-!      ecmwf routine METHOX
+!      ECMWF routine METHOX
        CALL METHOX(1,klon,klon,klev,q_seri,d_q_ch4,pplay)
 #endif
-       ! ajout de la tendance d'humidite due au methane
+       ! add humidity tendency due to methane
        d_q_ch4_dtime(:,:) = d_q_ch4(:,:)*phys_tstep
 #ifdef ISO
@@ -6214 +6214 @@
 #endif      
      &   )
-       d_q_ch4(:,:) = d_q_ch4_dtime(:,:)/phys_tstep
-#ifdef ISO
-       d_xt_ch4(:,:,:) = d_xt_ch4_dtime(:,:,:)/phys_tstep
+       d_q_ch4(:,:) = d_q_ch4_dtime(:,:)/phys_tstep ! update with H2O conserv done in add_phys_tend
+#ifdef ISO
+       d_xt_ch4(:,:,:) = d_xt_ch4_dtime(:,:,:)/phys_tstep ! update with H2O conserv done in add_phys_tend
 #endif
     ENDIF